Re: [PATCH net-next 09/11] bnxt_en: bnxt: add TC flower filter offload support

Mon, Sep 18, 2017 at 11:43:22AM CEST, sathya.perla@broadcom.com wrote:

On Mon, Sep 11, 2017 at 7:06 PM, Jiri Pirko [off-list ref] wrote:

quoted

Mon, Aug 28, 2017 at 07:40:33PM CEST, michael.chan@broadcom.com wrote:

quoted

From: Sathya Perla <redacted>

This patch adds support for offloading TC based flow
rules and actions for the 'flower' classifier in the bnxt_en driver.
It includes logic to parse flow rules and actions received from the
TC subsystem, store them and issue the corresponding
hwrm_cfa_flow_alloc/free FW cmds. L2/IPv4/IPv6 flows and drop,
redir, vlan push/pop actions are supported in this patch.

In this patch the hwrm_cfa_flow_xxx routines are just stubs.
The code for these routines is introduced in the next patch for easier
review. Also, the code to query the TC/flower action stats will
be introduced in a subsequent patch.

Hi.

You are missing checks for the offload. Please see nfp as an example:
Function nfp_flower_setup_tc:

            !is_classid_clsact_ingress(cls_flower->common.classid) ||
            cls_flower->common.chain_index)

Thanks for catching this...will send a patch.

quoted

Do you support both ingress and egress or ingress only?

Ingress only for flower offload.

Cool, the check would resolve it. Thanks!