Re: [PATCH] bgmac: Remove all offloading features, including GRO.

you're absolutely correct. will send an updated version shortly.

On Fri, 2017-09-15 at 16:14 -0700, David Miller wrote:

From: Rosen Penev <redacted>
Date: Fri, 15 Sep 2017 15:22:18 -0700

quoted

On a linksys E1200v1 (actually a crossflashed E1000v2), the

offloading features give no measurable benefit to speed or latency.
Furthermore, disabling GRO actually improves iperf performance by a
whoppimg 3mbps. Results:
 ...

quoted

-     net_dev->features = NETIF_F_SG | NETIF_F_IP_CSUM |

NETIF_F_IPV6_CSUM;

quoted

+     net_dev->features &= NETIF_F_GRO;
      net_dev->hw_features = net_dev->features;

This doesn't disable GRO.