Re: [PATCH v2] vxlan: only reduce known arp broadcast request to support virtual IP
From: Jiri Benc <hidden>
Date: 2017-09-14 16:14:06
On Thu, 14 Sep 2017 23:14:40 +0800, Chen Haiquan wrote:
quoted hunk ↗ jump to hunk
+static bool arp_reduce_ignore_unknown_ip; +module_param(arp_reduce_ignore_unknown_ip, bool, 0644); +MODULE_PARM_DESC(arp_reduce_ignore_unknown_ip, + "Only reduce known arp broaddcast request to support virtual IP");
Oh, no. This is not the way. It needs to be a runtime configuration option (a netlink attribute). Generally, every time you find yourself adding a module parameter, you're doing something wrong. Also, net-next is currently closed. You should not submit new features during this period, it's bugfixes only now. http://vger.kernel.org/~davem/net-next.html Jiri