Thread (5 messages) flat view 5 messages, 3 authors, 2017-09-09

Re: [PATCH net] Revert "mdio_bus: Remove unneeded gpiod NULL check"

From: David Miller <davem@davemloft.net>
Date: 2017-09-09 04:13:23

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri,  8 Sep 2017 15:38:07 -0700
This reverts commit 95b80bf3db03c2bf572a357cf74b9a6aefef0a4a ("mdio_bus:
Remove unneeded gpiod NULL check"), this commit assumed that GPIOLIB
checks for NULL descriptors, so it's safe to drop them, but it is not
when CONFIG_GPIOLIB is disabled in the kernel. If we do call
gpiod_set_value_cansleep() on a GPIO descriptor we will issue warnings
coming from the inline stubs declared in include/linux/gpio/consumer.h.

Fixes: 95b80bf3db03 ("mdio_bus: Remove unneeded gpiod NULL check")
Reported-by: Woojung Huh <Woojung.Huh@microchip.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help