Thread (3 messages) flat view 3 messages, 3 authors, 2017-09-08

Re: [PATCH net] tcp: fix a request socket leak

From: David Miller <davem@davemloft.net>
Date: 2017-09-08 23:08:18

From: Alexei Starovoitov <redacted>
Date: Fri, 8 Sep 2017 15:59:23 -0700
On Fri, Sep 08, 2017 at 12:44:47PM -0700, Eric Dumazet wrote:
quoted
From: Eric Dumazet <edumazet@google.com>

While the cited commit fixed a possible deadlock, it added a leak
of the request socket, since reqsk_put() must be called if the BPF
filter decided the ACK packet must be dropped.

Fixes: d624d276d1dd ("tcp: fix possible deadlock in TCP stack vs BPF filter")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
David, this is a stable candidate (linux-4.13 has this bug)
Thanks for the fix
Acked-by: Alexei Starovoitov <ast@kernel.org>
.. since the fix makes sense to me and as a reminder not to forget
to backport it as well :)
Applied and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help