Thread (7 messages) flat view 7 messages, 4 authors, 2017-09-08

Re: [PATCH net] ipv6: fix memory leak with multiple tables during netns destruction

From: David Miller <davem@davemloft.net>
Date: 2017-09-08 16:49:19

From: Sabrina Dubroca <sd@queasysnail.net>
Date: Fri,  8 Sep 2017 10:26:19 +0200
fib6_net_exit only frees the main and local tables. If another table was
created with fib6_alloc_table, we leak it when the netns is destroyed.

Fix this in the same way ip_fib_net_exit cleans up tables, by walking
through the whole hashtable of fib6_table's. We can get rid of the
special cases for local and main, since they're also part of the
hashtable.

Reproducer:
    ip netns add x
    ip -net x -6 rule add from 6003:1::/64 table 100
    ip netns del x

Reported-by: Jianlin Shi <redacted>
Fixes: 58f09b78b730 ("[NETNS][IPV6] ip6_fib - make it per network namespace")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help