On 31/08/2017 21:18, Florian Fainelli wrote:

On 08/31/2017 12:09 PM, Mason wrote:

quoted

On 31/08/2017 19:03, Florian Fainelli wrote:

quoted

On 08/31/2017 05:29 AM, Marc Gonzalez wrote:

quoted

On 31/08/2017 02:49, Florian Fainelli wrote:

quoted

The original motivation for this change originated from Marc Gonzalez
indicating that his network driver did not have its adjust_link callback
executing with phydev->link = 0 while he was expecting it.

I expect the core to call phy_adjust_link() for link changes.
This used to work back in 3.4 and was broken somewhere along
the way.

If that was working correctly in 3.4 surely we can look at the diff and
figure out what changed, even maybe find the offending commit, can you
do that?

Bisecting would a be a huge pain because my platform was
not upstream until v4.4

Then just diff the file and try to pinpoint which commit may have
changed that?

Running 'ip link set eth0 down' on the command-line.

In v3.4 => adjust_link() callback is called
In v4.5 => adjust_link() callback is NOT called

$ git log --oneline --no-merges v3.4..v4.5 drivers/net/phy/phy.c | wc -l
59

I'm not sure what "just diff the file" entails.
I can't move 3.4 up, nor move 4.5 down.
I'm not even sure the problem comes from drivers/net/phy/phy.c
to be honest.

Regards.