Thread (9 messages) 9 messages, 4 authors, 2017-09-03

Re: [PATCH net-next 2/2] net: convert (struct ubuf_info)->refcnt to refcount_t

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2017-09-03 03:39:43

On Sat, Sep 2, 2017 at 5:58 PM, kbuild test robot [off-list ref] wrote:
Hi Eric,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-ubuf_info-refcnt-conversion/20170903-043506
config: i386-randconfig-i1-201736 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386

All warnings (new ones prefixed by >>):

   drivers//vhost/net.c: In function 'handle_tx':
quoted
quoted
drivers//vhost/net.c:536:4: warning: passing argument 1 of 'atomic_set' from incompatible pointer type [enabled by default]
       atomic_set(&ubuf->refcnt, 1);
       ^
   In file included from include/linux/atomic.h:4:0,
                    from arch/x86/include/asm/thread_info.h:53,
                    from include/linux/thread_info.h:37,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:80,
                    from include/linux/spinlock.h:50,
                    from include/linux/wait.h:8,
                    from include/linux/eventfd.h:12,
                    from drivers//vhost/net.c:10:
   arch/x86/include/asm/atomic.h:36:29: note: expected 'struct atomic_t *' but argument is of type 'struct refcount_t *'
    static __always_inline void atomic_set(atomic_t *v, int i)
                                ^
This is a false positive. This patch

  [net-next,2/2] net: convert (struct ubuf_info)->refcnt to refcount_t
  http://patchwork.ozlabs.org/patch/808402/

was superseded by

  [v2,net-next,2/2] net: convert (struct ubuf_info)->refcnt to refcount_t
  http://patchwork.ozlabs.org/patch/808477/

which has been merged into net-next as commit c1d1b437816f

That patch has the necessary change:

-                      atomic_set(&ubuf->refcnt, 1);
+                       refcount_set(&ubuf->refcnt, 1);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help