Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

Hi Andreas,

[auto build test ERROR on staging/staging-testing]
[cannot apply to v4.13-rc7 next-20170901]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andreas-Ziegler/staging-r8822be-Fix-typo-for-CONFIG_RTLWIFI_DEBUG/20170830-144151
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/staging//rtlwifi/halmac/rtl_halmac.c: In function 'deinit_priv':

quoted

drivers/staging//rtlwifi/halmac/rtl_halmac.c:395:22: error: 'struct rtl_halmac_indicator' has no member named 'sctx'

        if (!indicator[i].sctx)
                         ^
   In file included from drivers/staging//rtlwifi/halmac/../wifi.h:38:0,
                    from drivers/staging//rtlwifi/halmac/halmac_2_platform.h:28,
                    from drivers/staging//rtlwifi/halmac/halmac_api.h:38,
                    from drivers/staging//rtlwifi/halmac/rtl_halmac.c:26:
   drivers/staging//rtlwifi/halmac/rtl_halmac.c:399:6: error: 'rtlpriv' undeclared (first use in this function)
         rtlpriv, COMP_HALMAC, DBG_LOUD,
         ^
   drivers/staging//rtlwifi/halmac/../debug.h:185:17: note: in definition of macro 'RT_TRACE'
     _rtl_dbg_trace(rtlpriv, comp, level,    \
                    ^~~~~~~
   drivers/staging//rtlwifi/halmac/rtl_halmac.c:399:6: note: each undeclared identifier is reported only once for each function it appears in
         rtlpriv, COMP_HALMAC, DBG_LOUD,
         ^
   drivers/staging//rtlwifi/halmac/../debug.h:185:17: note: in definition of macro 'RT_TRACE'
     _rtl_dbg_trace(rtlpriv, comp, level,    \
                    ^~~~~~~
   drivers/staging//rtlwifi/halmac/rtl_halmac.c:403:24: error: 'struct rtl_halmac_indicator' has no member named 'sctx'
        sctx = indicator[i].sctx;
                           ^
   drivers/staging//rtlwifi/halmac/rtl_halmac.c:404:17: error: 'struct rtl_halmac_indicator' has no member named 'sctx'
        indicator[i].sctx = NULL;
                    ^
   drivers/staging//rtlwifi/halmac/rtl_halmac.c:405:5: error: implicit declaration of function 'rtl_mfree' [-Werror=implicit-function-declaration]
        rtl_mfree((u8 *)sctx, sizeof(*sctx));
        ^~~~~~~~~

quoted

drivers/staging//rtlwifi/halmac/rtl_halmac.c:405:34: error: dereferencing pointer to incomplete type 'struct submit_ctx'

        rtl_mfree((u8 *)sctx, sizeof(*sctx));
                                     ^~~~~
   cc1: some warnings being treated as errors

vim +405 drivers/staging//rtlwifi/halmac/rtl_halmac.c

938a0447 Ping-Ke Shih    2017-08-17  378  
938a0447 Ping-Ke Shih    2017-08-17  379  static void deinit_priv(struct rtl_halmac *halmac)
938a0447 Ping-Ke Shih    2017-08-17  380  {
938a0447 Ping-Ke Shih    2017-08-17  381  	struct rtl_halmac_indicator *indicator;
938a0447 Ping-Ke Shih    2017-08-17  382  
938a0447 Ping-Ke Shih    2017-08-17  383  	indicator = halmac->indicator;
938a0447 Ping-Ke Shih    2017-08-17  384  	halmac->indicator = NULL;
938a0447 Ping-Ke Shih    2017-08-17  385  	if (indicator) {
938a0447 Ping-Ke Shih    2017-08-17  386  		u32 count, size;
938a0447 Ping-Ke Shih    2017-08-17  387  
938a0447 Ping-Ke Shih    2017-08-17  388  		count = HALMAC_FEATURE_ALL + 1;
bb304b2b Andreas Ziegler 2017-08-29  389  #ifdef CONFIG_RTLWIFI_DEBUG
938a0447 Ping-Ke Shih    2017-08-17  390  		{
938a0447 Ping-Ke Shih    2017-08-17  391  			struct submit_ctx *sctx;
938a0447 Ping-Ke Shih    2017-08-17  392  			u32 i;
938a0447 Ping-Ke Shih    2017-08-17  393  
938a0447 Ping-Ke Shih    2017-08-17  394  			for (i = 0; i < count; i++) {
938a0447 Ping-Ke Shih    2017-08-17 @395  				if (!indicator[i].sctx)
938a0447 Ping-Ke Shih    2017-08-17  396  					continue;
938a0447 Ping-Ke Shih    2017-08-17  397  
938a0447 Ping-Ke Shih    2017-08-17  398  				RT_TRACE(
938a0447 Ping-Ke Shih    2017-08-17  399  					rtlpriv, COMP_HALMAC, DBG_LOUD,
938a0447 Ping-Ke Shih    2017-08-17  400  					"%s: <WARN> %s id(%d) sctx still exist!!\n",
938a0447 Ping-Ke Shih    2017-08-17  401  					__func__, RTL_HALMAC_FEATURE_NAME[i],
938a0447 Ping-Ke Shih    2017-08-17  402  					i);
938a0447 Ping-Ke Shih    2017-08-17 @403  				sctx = indicator[i].sctx;
938a0447 Ping-Ke Shih    2017-08-17  404  				indicator[i].sctx = NULL;
938a0447 Ping-Ke Shih    2017-08-17 @405  				rtl_mfree((u8 *)sctx, sizeof(*sctx));
938a0447 Ping-Ke Shih    2017-08-17  406  			}
938a0447 Ping-Ke Shih    2017-08-17  407  		}
bb304b2b Andreas Ziegler 2017-08-29  408  #endif /* !CONFIG_RTLWIFI_DEBUG */
938a0447 Ping-Ke Shih    2017-08-17  409  		size = sizeof(*indicator) * count;
938a0447 Ping-Ke Shih    2017-08-17  410  		kfree((u8 *)indicator);
938a0447 Ping-Ke Shih    2017-08-17  411  	}
938a0447 Ping-Ke Shih    2017-08-17  412  }
938a0447 Ping-Ke Shih    2017-08-17  413  

:::::: The code at line 405 was first introduced by commit
:::::: 938a0447f094233e269f7f5ded474b13f3de8d80 staging: r8822be: Add code for halmac sub-driver

:::::: TO: Ping-Ke Shih [off-list ref]
:::::: CC: Greg Kroah-Hartman [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation