Thread (6 messages) 6 messages, 2 authors, 2017-08-31

Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link status changes

From: Antoine Tenart <hidden>
Date: 2017-08-31 13:53:09
Also in: lkml

Hi Andrew,

On Thu, Aug 31, 2017 at 03:47:24PM +0200, Andrew Lunn wrote:
On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote:
quoted
+static void mvpp22_gop_unmask_irq(struct mvpp2_port *port)
+{
+	u32 val;
+
+	if (port->phy_interface == PHY_INTERFACE_MODE_RGMII ||
+	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
+	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
+	    port->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID ||
phy_interface_mode_is_rgmii()
Right, and you already made that comment before... I'll fix it.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help