Thread (4 messages) 4 messages, 2 authors, 2017-08-22

Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-08-22 21:44:17
Also in: lkml

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 22 Aug 2017 14:26:47 -0700
Priit reported that stmmac was crashing with the trace below. This is because
phy_attached_print() is called too early right after the PHY device has been
found, but before it has a driver attached, since that is only done in
phy_probe() which occurs later.

Fix this by dealing with a possibly NULL phydev->drv point since that can
happen here, but could also happen if we voluntarily did an unbind of the
PHY device with the PHY driver.
 ...
Tested-By: Priit Laes <redacted>
Fixes: fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
"net-next"?  The commit which introduced this problem is in 'net', don't we want
to fix it there?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help