Re: [PATCH v2 1/2] net: stmmac: Delete dead code for MDIO registration
flat view
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-08-22 00:45:17
Also in:
lkml
On 08/21/2017 04:45 AM, Romain Perier wrote:
quoted hunk ↗ jump to hunk
This code is no longer used, the logging function was changed by commit fbca164776e4 ("net: stmmac: Use the right logging functi"). Fixes: fbca164776e4 ("net: stmmac: Use the right logging functi") Signed-off-by: Romain Perier <redacted> --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 16 ---------------- 1 file changed, 16 deletions(-)diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index 72ec711fcba2..f5f37bfa1d58 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c@@ -248,9 +248,6 @@ int stmmac_mdio_register(struct net_device *ndev) found = 0; for (addr = 0; addr < PHY_MAX_ADDR; addr++) { struct phy_device *phydev = mdiobus_get_phy(new_bus, addr); - int act = 0; - char irq_num[4]; - char *irq_str; if (!phydev) continue;@@ -273,19 +270,6 @@ int stmmac_mdio_register(struct net_device *ndev) if (priv->plat->phy_addr == -1) priv->plat->phy_addr = addr; - act = (priv->plat->phy_addr == addr); - switch (phydev->irq) { - case PHY_POLL: - irq_str = "POLL"; - break; - case PHY_IGNORE_INTERRUPT: - irq_str = "IGNORE"; - break; - default: - sprintf(irq_num, "%d", phydev->irq); - irq_str = irq_num; - break; - }
I was actually just looking into moving these prints to
phy_attached_info(), since it is useful to know whether the interrupt is
POLL, IGNORE, or valid. Can you move that there? Then you can really
migrate over phy_attached_info() with no information loss.
Thanks!
--
Florian