Thread (2 messages) 2 messages, 2 authors, 2017-08-21

Re: [PATCH v2] net: ibm: emac: Fix some error handling path in 'emac_probe()'

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-08-21 02:53:23
Also in: kernel-janitors, lkml

From: Christophe JAILLET <redacted>
Date: Sun, 20 Aug 2017 06:35:00 +0200
If 'irq_of_parse_and_map()' or 'of_address_to_resource()' fail, 'err' is
known to be 0 at this point.
So return -ENODEV instead in the first case and use 'of_iomap()' instead of
the equivalent 'of_address_to_resource()/ioremap()' combinaison in the 2nd
case.

Doing so, the 'rsrc_regs' field of the 'emac_instance struct' becomes
redundant and is removed.

While at it, turn a 'err != 0' test into an equivalent 'err' to be more
consistent.

Signed-off-by: Christophe JAILLET <redacted>
---
v2: use of_iomap() to simplify code
    remove 'rsrc_regs' field of the 'emac_instance struct'
    update comment
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help