Re: [PATCH][next] net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout
flat view
From: David Miller <davem@davemloft.net>
Date: 2017-08-09 04:08:02
Also in:
kernel-janitors, lkml
From: Colin King <redacted> Date: Tue, 8 Aug 2017 10:52:32 +0100
From: Colin Ian King <redacted>
Change post-decrement compare to pre-decrement to avoid an
unsigned integer wrap-around on timeout. This leads to the following
!timeout check to never to be true so -ETIMEDOUT is never returned.
Detected by CoverityScan, CID#1452623 ("Logically dead code")
Fixes: 69a60b0579a4 ("net: phy: mdio-bcm-unimac: factor busy polling loop")
Signed-off-by: Colin Ian King <redacted>Applied.