Thread (22 messages) 22 messages, 3 authors, 2017-08-01

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

From: Andrew Lunn <andrew@lunn.ch>
Date: 2017-08-01 14:28:46
Also in: lkml

On Mon, Jul 31, 2017 at 06:17:18PM -0400, Vivien Didelot wrote:
The PHY's EEE settings are already accessed by the DSA layer through the
Marvell PHY driver and there is nothing to be done for switch's MACs.
I'm confused, or missing something. Does not patch #1 mean that if the
DSA driver does not have a set_eee function, we always return -ENODEV
in slave.c?

There might be nothing to configure here, but some of the switches do
support EEE. So we need at least a NOP set_eee. Better still it should
return -ENODEV for those switches which don't actually support EEE,
and 0 for those that do?

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help