Re: [PATCH net-next 3/4] net/core: Add violation counters to VF statisctics

On Mon, Aug 28, 2017 at 3:43 AM, Jakub Kicinski [off-list ref] wrote:

On Sun, 27 Aug 2017 14:06:17 +0300, Saeed Mahameed wrote:

quoted

From: Eugenia Emantayev <redacted>

Add receive and transmit violation counters to be
displayed in iproute2 VF statistics.

Signed-off-by: Eugenia Emantayev <redacted>
Signed-off-by: Saeed Mahameed <redacted>
---
 include/linux/if_link.h      |  2 ++
 include/uapi/linux/if_link.h |  2 ++
 net/core/rtnetlink.c         | 10 +++++++++-
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index da70af27e42e..ebf3448acb5b 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h

@@ -12,6 +12,8 @@ struct ifla_vf_stats {
      __u64 tx_bytes;
      __u64 broadcast;
      __u64 multicast;
+     __u64 rx_dropped;
+     __u64 tx_dropped;

I'm a little concerned that you call those violation counters in the
commit message.  Do you expect them to only be used if the VF traffic
indeed violates some admin-set rules?  I would imaging HW/FW may drop
frames in certain situations and naming the counters *_dropped suggests
it would be OK to increment them even if the drop reason was not any
sort of violation.  Would you mind clarifying?

Yes, the rx/tx_dropped counters serve as a general purpose VF drop
counter including VF violations.
We will fix the commit message.

Thanks !
Saeed.