Thread (21 messages) 21 messages, 5 authors, 2017-08-24

Re: [net-next 10/15] net/mlx5: Add a blank line after declarations

flat view

From: Joe Perches <joe@perches.com>
Date: 2017-08-23 23:16:12

On Thu, 2017-08-17 at 16:29 +0300, Saeed Mahameed wrote:
From: Or Gerlitz <redacted>
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
[]
quoted hunk ↗ jump to hunk
@@ -188,6 +188,7 @@ static enum mlx5_dev_event port_subtype_event(u8 subtype)
 static void eq_update_ci(struct mlx5_eq *eq, int arm)
 {
 	__be32 __iomem *addr = eq->doorbell + (arm ? 0 : 2);
+
 	u32 val = (eq->cons_index & 0xffffff) | (eq->eqn << 24);
 	__raw_writel((__force u32)cpu_to_be32(val), addr);
 	/* We still want ordering, just not swabbing, so add a barrier */
checkpatch is stupid.

The blank line should be after u32 val = ...
and not after __be32 __iomem *addr = ...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help