Thread (4 messages) 4 messages, 3 authors, 2017-08-22

Re: [PATCH 1/2] vhost: remove the possible fruitless search on iotlb prefetch

From: Koichiro Den <hidden>
Date: 2017-08-22 14:09:44
Also in: kvm, virtualization

On Mon, 2017-08-21 at 22:45 +0300, Michael S. Tsirkin wrote:
On Sat, Aug 19, 2017 at 03:41:14PM +0900, Koichiro Den wrote:
quoted
Signed-off-by: Koichiro Den <redacted>
---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index e4613a3c362d..93e909afc1c3 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1184,7 +1184,7 @@ static int iotlb_access_ok(struct vhost_virtqueue *vq,
 	while (len > s) {
 		node = vhost_umem_interval_tree_iter_first(&umem-
quoted
umem_tree,
 							   addr,
-							   addr + len - 1);
+							   addr + len - s -
1);
 		if (node == NULL || node->start > addr) {
 			vhost_iotlb_miss(vq, addr, access);
 			return false;
This works but it probably makes sense to just refactor the code to make end
of
range a variable. I posted a patch like this, pls take a look.
quoted
-- 
2.9.4
Ok, thanks.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help