Thread (3 messages) 3 messages, 2 authors, 2017-08-20

Re: [PATCH net-next] cxgb4/cxgbvf: Handle 32-bit fw port capabilities

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-08-20 04:34:31

From: David Miller <davem@davemloft.net>
Date: Sat, 19 Aug 2017 21:32:40 -0700 (PDT)
From: Ganesh Goudar <redacted>
Date: Fri, 18 Aug 2017 21:21:32 +0530
quoted
Implement new 32-bit Firmware Port Capabilities in order to
handle new speeds which couldn't be represented in the old 16-bit
Firmware Port Capabilities values.

Based on the original work of Casey Leedom [off-list ref]

Signed-off-by: Ganesh Goudar <redacted>
Applied.
Reverted, this doesn't even build!

[davem@localhost net-next]$ make -s -j8
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function ‘fwevtq_handler’:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:534:50: error: expected ‘)’ before ‘{’ token
        action == FW_PORT_ACTION_GET_PORT_INFO32) {
                                                  ^
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:560:2: error: expected expression before ‘}’ token
  } else if (opcode == CPL_L2T_WRITE_RPL) {
  ^
At top level:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:463:13: warning: ‘dcb_rpl’ defined but not used [-Wunused-function]
 static void dcb_rpl(struct adapter *adap, const struct fw_port_cmd *pcmd)
             ^~~~~~~
make[5]: *** [scripts/Makefile.build:303: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [scripts/Makefile.build:561: drivers/net/ethernet/chelsio/cxgb4] Error 2
make[3]: *** [scripts/Makefile.build:561: drivers/net/ethernet/chelsio] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:561: drivers/net/ethernet] Error 2
make[1]: *** [scripts/Makefile.build:561: drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1019: drivers] Error 2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help