Thread (10 messages) 10 messages, 2 authors, 2017-08-18

Re: [iproute PATCH v2 1/7] ipaddress: Make buffer for filter.flushb static

flat view

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-08-18 15:55:27

On Fri, 18 Aug 2017 13:57:03 +0200
Phil Sutter [off-list ref] wrote:
On Thu, Aug 17, 2017 at 07:09:25PM +0200, Phil Sutter wrote:
quoted
The buffer is accessed outside of the function defining it, so make it
static.

Signed-off-by: Phil Sutter <phil@nwl.cc>  
Self-NACK: Access to flushb should be sane since all accessors are
called from ipaddr_flush(). Looking at the covscan output again, it
merely complained about filter.flusb still pointing to the local buffer
when ipaddr_flush() returns.

Cheers, Phil
Ok, dropping this  sub-series
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help