Re: [PATCH 2/2] xdp: adjust xdp redirect tracepoint to include return error code

On 08/18/2017 02:29 PM, Jesper Dangaard Brouer wrote:

On Thu, 17 Aug 2017 12:43:18 -0700
John Fastabend [off-list ref] wrote:

quoted

quoted

quoted

quoted

@@ -2532,12 +2535,14 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp,
  	ri->map = NULL;
  	if (unlikely(!fwd)) {
  		bpf_warn_invalid_xdp_redirect(index);

I think we should drop the warn_invalid now that we have a tracepoint.
The tracepoint is much nicer for debugging vs a warning for what might
be a valid case depending on xdp program.

I agree.  I'll do that in a follow up patch. I'll likely remove the
bpf_warn_invalid_xdp_redirect() function completely.

+1

We also have bpf_warn_invalid_xdp_action() but that might be relevant
to keep around(?).

Keeping this is fine, imo.