Thread (7 messages) 7 messages, 3 authors, 2017-08-18

RE: [iproute PATCH v2 2/2] ifcfg: Quote left-hand side of [ ] expression

flat view

From: David Laight <hidden>
Date: 2017-08-18 09:32:57

From: Phil Sutter
quoted hunk ↗ jump to hunk
Sent: 17 August 2017 18:10
This prevents word-splitting and therefore leads to more accurate error
message in case 'grep -c' prints something other than a number.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 ip/ifcfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ifcfg b/ip/ifcfg
index 083d9df36742f..30a2dc49816cd 100644
--- a/ip/ifcfg
+++ b/ip/ifcfg
@@ -131,7 +131,7 @@ noarp=$?

 ip route add unreachable 224.0.0.0/24 >& /dev/null
 ip route add unreachable 255.255.255.255 >& /dev/null
-if [ `ip link ls $dev | grep -c MULTICAST` -ge 1 ]; then
+if [ "`ip link ls $dev | grep -c MULTICAST`" -ge 1 ]; then
You could drag all these scripts into the 1990's by using $(...)
instead of `...`.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help