Re: [RFC] about net: Fix inconsistent teardown and release of private netdev state.

From: Eric Dumazet <redacted>
Date: Thu, 17 Aug 2017 15:30:40 -0700

So we do not really know if we need to clean up or not.

We always know, the answer is that whenever register_netdev() fails we
never need to perform any cleanup which is done by priv_destructor.

Any idea how to fix the issue ?

Your patch is exactly how we should fix this, but without the comment.
The logic is straightforward.

If register_netdevice() fails any resources handled by priv_destructor
are cleaned up, it is guaranteed.