Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

On Wed, Aug 16, 2017 at 1:39 AM, Xin Long [off-list ref] wrote:

On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang [off-list ref] wrote:

quoted

On Mon, Aug 7, 2017 at 7:33 PM, Xin Long [off-list ref] wrote:

quoted

On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang [off-list ref] wrote:

quoted

This looks like a completely API burden?

netfilter xt targets are not really compatible with netsched action.
I've got to say, the patch is just a way to make checkentry return
false and avoid panic. like [1] said

I don't doubt you fix a crash, I am thinking if we can
"fix" the API instead of fixing the caller.

Hi, Cong,

For now, I don't think it's possible to change APIs or  some of their targets
for the panic caused by action xt calling.

The common way should be fixed in net_sched side.

Given that the issue is very easy to triggered,
let's wait for netfilter's replies for another few days,
otherwise I will repost the fix, agree ?

Yeah, no objections from me.

By the way, do you know how other callers of this API
use 'entryinfo'? Do they pass the address of the struct
on stack too?