Thread (3 messages) 3 messages, 3 authors, 2017-08-15

Re: [PATCH net] af_key: do not use GFP_KERNEL in atomic contexts

flat view

From: David Ahern <hidden>
Date: 2017-08-14 23:07:29

On 8/14/17 11:16 AM, Eric Dumazet wrote:
From: Eric Dumazet <redacted>

pfkey_broadcast() might be called from non process contexts,
we can not use GFP_KERNEL in these cases [1].

This patch partially reverts commit ba51b6be38c1 ("net: Fix RCU splat in
af_key"), only keeping the GFP_ATOMIC forcing under rcu_read_lock()
section.

[1] : syzkaller reported :
...
Fixes: ba51b6be38c1 ("net: Fix RCU splat in af_key")
Signed-off-by: Eric Dumazet <redacted>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: David Ahern <redacted>
---
 net/key/af_key.c |   48 ++++++++++++++++++++++++---------------------
 1 file changed, 26 insertions(+), 22 deletions(-)
Thanks for the fix, Eric.

Acked-by: David Ahern <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help