Thread (2 messages) 2 messages, 2 authors, 2017-08-11

Re: [PATCH net-next] geneve: use netlink_ext_ack for error reporting in rtnl operations

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-08-11 20:45:18

From: Girish Moodalbail <redacted>
Date: Wed,  9 Aug 2017 01:09:28 -0700
Add extack error messages for failure paths while creating/modifying
geneve devices. Once extack support is added to iproute2, more
meaningful and helpful error messages will be displayed making it easy
for users to discern what went wrong.

Before:
=======
$ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
  remote 192.168.13.2
RTNETLINK answers: Invalid argument

After:
======
$ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
  remote 192.168.13.2
Error: Provided link layer address is not Ethernet

Also, netdev_dbg() calls used to log errors associated with Netlink
request have been removed.

Signed-off-by: Girish Moodalbail <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help