Thread (14 messages) 14 messages, 3 authors, 2017-08-16

Re: [PATCH 1/2] mpls: add handlers

flat view

From: Roopa Prabhu <hidden>
Date: 2017-08-11 14:37:23

On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter [off-list ref] wrote:
On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote:
quoted
Mpls handler allows creation/deletion of mpls routes without using
rtnetlink. When an incoming mpls packet matches this route, the saved
function handler is called.
Since I originally authored this patch, I have come to believe that it
might be unneccessarily complicated.  It is unlikely that a lot of
different "handlers" will exist here;  the only things I can think of
are VPLS support and BIER-MPLS multicast replication.  I'm not saying
it's a bad idea, but, well, this was in the README that I gave to 6WIND
with this code:

...
yes, I would also prefer just exporting the functions  and calling
them directly instead of adding a
handler layer. We can move to that later if it becomes necessary.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help