Re: [PATCH v2 iproute2] lib: Dump ext-ack string by default

On 8/9/17 1:38 AM, Girish Moodalbail wrote:

quoted

@@ -99,7 +95,16 @@ static int nl_dump_ext_err(const struct nlmsghdr

*nlh, nl_ext_ack_fn_t errfn)
              err_nlh = &err->msg;
      }
  -    return errfn(errmsg, off, err_nlh);
+    if (errfn)
+        return errfn(errmsg, off, err_nlh);
+
+    if (errmsg) {
+        fprintf(stderr, "Error: %s\n", errmsg);

Should the above output end with a period '.'? All the error messages in
the Kernel are statements without a terminating period, so the output

no guarantee of that, but iproute2 could check for it and add it.