Re: [PATCH v3 net-next 3/5] sock: ULP infrastructure
flat view
From: John Fastabend <john.fastabend@gmail.com>
Date: 2017-08-08 10:16:22
On 08/07/2017 10:28 AM, Tom Herbert wrote:
Generalize the TCP ULP infrastructure recently introduced to support kTLS. This adds a SO_ULP socket option and creates new fields in sock structure for ULP ops and ULP data. Also, the interface allows additional per ULP parameters to be set so that a ULP can be pushed and operations started in one shot. Signed-off-by: Tom Herbert <redacted> ---
I think this generalization should not get committed until it has a user. I see you posted the socktap stuff but that is just an RFC for now. [...]
quoted hunk ↗ jump to hunk
+ +static inline void ulp_get_available(char *buf, size_t len) +{
Do we need to check len field or is len == 0 invalid?
quoted hunk ↗ jump to hunk
+ *buf = '\0'; +} + +static inline void ulp_cleanup(struct sock *sk) +{ +} +
[...] Rest looks OK I'll take a closer look tomorrow at this and the RFC user. Thanks, John