Thread (3 messages) 3 messages, 2 authors, 2017-08-07

Re: [PATCH net 1/1] s390/qeth: fix L3 next-hop in xmit qeth hdr

flat view

From: David Miller <davem@davemloft.net>
Date: 2017-08-07 18:25:31
Also in: linux-s390

From: Ursula Braun <redacted>
Date: Mon,  7 Aug 2017 13:28:39 +0200
From: Julian Wiedmann <redacted>

On L3, the qeth_hdr struct needs to be filled with the next-hop
IP address.
The current code accesses rtable->rt_gateway without checking that
rtable is a valid address. The accidental access to a lowcore area
results in a random next-hop address in the qeth_hdr.
rtable (or more precisely, skb_dst(skb)) can be NULL in rare cases
(for instance together with AF_PACKET sockets).
This patch adds the missing NULL-ptr checks.

Signed-off-by: Julian Wiedmann <redacted>
Signed-off-by: Ursula Braun <redacted>
Fixes: 87e7597b5a3 qeth: Move away from using neighbour entries in qeth_l3_fill_header()
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help