Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
flat view
From: David Miller <davem@davemloft.net>
Date: 2017-08-07 06:09:05
From: Jiri Pirko <jiri@resnulli.us> Date: Mon, 7 Aug 2017 07:27:34 +0200
Mon, Aug 07, 2017 at 06:37:49AM CEST, davem@davemloft.net wrote:quoted
From: Jiri Pirko <jiri@resnulli.us> Date: Sat, 5 Aug 2017 16:53:22 +0200quoted
From: Jiri Pirko <redacted> This patchset focuses on ndo_setup_tc and its args. Currently there are couple of things that do not make much sense. The type is passed in struct tc_to_netdev, but as it is always required, should be arg of the ndo. Other things are passed as args but they are only relevant for cls offloads and not mqprio. Therefore, they should be pushed to struct. As the tc_to_netdev struct in the end is just a container of single pointer, we get rid of it and pass the struct according to type. So in the end, we have: ndo_setup_tc(dev, type, type_data_struct) There are couple of cosmetics done on the way to make things smooth. Also, reported error is consolidated to eopnotsupp in case the asked offload is not supported.Series applied, thanks Jiri.Pushed this already? I just got an email from kbuildbot, I missed hns3pf driver (3 days). I can send the fix as followup as well. Up to you.
Luckily I didn't push yet, please respin with hns3pf fixed, thanks!