Re: uapi: MAX_ADDR_LEN vs. numeric 32

On Sat, Aug 05, 2017 at 01:25:19AM +0300, Dmitry V. Levin wrote:

On Sat, Aug 05, 2017 at 12:33:25AM +0300, Mikko Rapeli wrote:

quoted

I find using MAX_ADDR_LEN better than numeric 32, though I doubt this will
change any time soon. Would you mind if I change packet_diag.h and
if_link.h to use that instead and fix the userspace compilation
problems by including netdevice.h?

The alternative fix, that is, to include <linux/netdevice.h>
which pulls in other headers and a lot of definitions with them,
has been mentioned in the discussion, too.
We decided that the fix that was applied would be the least of all evils.

Ok, that's fine then. I'll drop my netdevice.h inclusion patch.

Thanks,

-Mikko