Re: [PATCH net] mcs7780: Silence uninitialized variable warning

On Mon, Jul 31, 2017 at 10:37:16AM -0700, David Miller wrote:

From: Dan Carpenter <redacted>
Date: Mon, 31 Jul 2017 10:41:40 +0300

quoted

On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote:

quoted

From: Dan Carpenter <redacted>
Date: Fri, 28 Jul 2017 17:45:11 +0300

quoted

-	__u16 rval;
+	__u16 rval = -1;

Fixing a bogus warning by assigning a signed constant to an
unsigned variable doesn't really make me all that happy.

I don't think I'll apply this, sorry.

There's no guarantee that small kmallocs will always succeed in future
kernels so it's not *totally* bogus.

Perhaps the burdon of initializing the value belongs in
mcs_get_reg(), and you can set it properly to 0xffff
instead of -1.

Ok?

Sure.  I will resend.

thanks,
dan carpenter