Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

On Tue, Aug 1, 2017 at 2:01 PM, David Ahern [off-list ref] wrote:

On 7/31/17 7:40 PM, Xin Long wrote:

quoted

To respect the old code more, setting RTPROT_RA only when
it's with the flag (ADDRCONF | DEFAULT | ROUTEINFO),
shouldn't it be:

Look at rtm_fill_info:

        if (rt->rt6i_flags & (RTF_DEFAULT | RTF_ROUTEINFO))
                        rtm->rtm_protocol = RTPROT_RA;


If either flag is set the protocol should be RTPROT_RA and looking at
both places that seems correct to me.

ok, right