Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()
From: David Miller <davem@davemloft.net>
Date: 2017-08-01 00:28:19
From: David Miller <davem@davemloft.net>
Date: 2017-08-01 00:28:19
From: Florian Fainelli <f.fainelli@gmail.com> Date: Fri, 28 Jul 2017 11:58:36 -0700
Marc reported that he was not getting the PHY library adjust_link()
callback function to run when calling phy_stop() + phy_disconnect()
which does not indeed happen because we set the state machine to
PHY_HALTED but we don't get to run it to process this state past that
point.
Fix this with a synchronous call to phy_state_machine() in order to have
the state machine actually act on PHY_HALTED, set the PHY device's link
down, turn the network device's carrier off and finally call the
adjust_link() function.
Reported-by: Marc Gonzalez <redacted>
Fixes: a390d1f379cf ("phylib: convert state_queue work to delayed_work")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- reword subject and commit message based on changes
- dropped flush_scheduled_work() since it is redundantApplied and queued up for -stable, thanks.