Thread (1 message) 1 message, 1 author, 2017-07-21
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

Re: [PATCH v2 2/4] net: ethernet: nb8800: Set RGMII_MODE for all RGMII modes

From: Måns Rullgård <hidden>
Date: 2017-07-21 13:00:57
Also in: linux-arm-kernel

Marc Gonzalez [off-list ref] writes:
There are 4 RGMII phy-modes to handle.

Signed-off-by: Marc Gonzalez <redacted>
Acked-by: Mans Rullgard <redacted>
quoted hunk
---
 drivers/net/ethernet/aurora/nb8800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 041cfb7952f8..ded041dbafe7 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -609,7 +609,7 @@ static void nb8800_mac_config(struct net_device *dev)
 		mac_mode |= HALF_DUPLEX;

 	if (gigabit) {
-		if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII)
+		if (phy_interface_is_rgmii(dev->phydev))
 			mac_mode |= RGMII_MODE;

 		mac_mode |= GMAC_MODE;
-- 
2.11.0
-- 
Måns Rullgård
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help