RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

-----Original Message-----
From: devicetree-owner@vger.kernel.org [mailto:devicetree-
owner@vger.kernel.org] On Behalf Of Sergei Shtylyov
Sent: 05 July 2017 14:21
To: Biju Das <redacted>; Rob Herring <robh+dt@kernel.org>;
Mark Rutland [off-list ref]; Russell King
[off-list ref]
Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
[off-list ref]; Chris Paterson
[off-list ref]; devicetree@vger.kernel.org; linux-renesas-
soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
netdev@vger.kernel.org
Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

Hello!

On 07/05/2017 04:01 PM, Biju Das wrote:

quoted

Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
Gen2 family.

Signed-off-by: Biju Das <redacted>
Reviewed-by: Chris Paterson <redacted>

[...]

quoted

diff --git a/drivers/net/ethernet/renesas/ravb_main.c

b/drivers/net/ethernet/renesas/ravb_main.c
index 5931e85..e35b30f 100644

--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c

@@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private

*priv)  }

 static const struct of_device_id ravb_match_table[] = {
+{ .compatible = "renesas,etheravb-r8a7743", .data = (void
+*)RCAR_GEN2 },

    No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2".

Thanks for the review. I will remove this change.

quoted

 { .compatible = "renesas,etheravb-r8a7790", .data = (void

*)RCAR_GEN2 },

quoted

 { .compatible = "renesas,etheravb-r8a7794", .data = (void

*)RCAR_GEN2 },

quoted

 { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
*)RCAR_GEN2 },

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body
of a message to majordomo@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
N�����r��y���b�X��ǧv�^�)޺{.n�+���z��z��z)���w*jg���
�����ݢj.�۰\��M��gj��a����' ��ޢ�
���j:+v���w�j�m��������zZ+�����ݢj"��!�i