Thread (5 messages) flat view 5 messages, 2 authors, 2017-07-29

Re: [PATCH 1/1] netfilter: constify nf_conntrack_l3/4proto parameters

From: Florian Westphal <fw@strlen.de>
Date: 2017-07-29 20:05:46
Also in: kernel-janitors, lkml, netfilter-devel

Julia Lawall [off-list ref] wrote:
When a nf_conntrack_l3/4proto parameter is not on the left hand side
of an assignment, its address is not taken, and it is not passed to a
function that may modify its fields, then it can be declared as const.

This change is useful from a documentation point of view, and can
possibly facilitate making some nf_conntrack_l3/4proto structures const
subsequently.

Done with the help of Coccinelle.

Some spacing adjusted to fit within 80 characters.
Acked-by: Florian Westphal <fw@strlen.de>

Thanks Julia.

I think we can indeed constify these completely after making
'nla_size' set at compile time.

I'll send a simple attempt to make it so for l3proto soon.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help