On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote:

Hi Joe,

I tried to be consistent with the comments before, that requested
that we will use dev_err exclude some special cases for use netif.

We will replace the dev_err(&netdev->dev,.. to netdev_err in the
next fix.

netdev_err() should be used when possible. You just have to be careful
in the probe() function, before netdev exists and you get "(NULL
net_device):" or before it is registered and you get "(unnamed
net_device)" instead of "eth42" etc.

	      Andrew