Thread (11 messages) 11 messages, 3 authors, 2017-07-26

Re: [PATCH net-next V2 0/5] Refine virtio-net XDP

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2017-07-24 21:41:13
Also in: lkml, virtualization

On Mon, Jul 24, 2017 at 01:38:59PM -0700, David Miller wrote:
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 19 Jul 2017 16:54:44 +0800
quoted
Hi:

This series brings two optimizations for virtio-net XDP:

- avoid reset during XDP set
- turn off offloads on demand

Changes from V1:
- Various tweaks on commit logs and comments
- Use virtnet_napi_enable() when enabling NAPI on XDP set
- Copy the small buffer packet only if xdp_headroom is smaller than
  required

Please review.
Series applied, thanks Jason.

Michael, I gave you 4+ days to properly review this respin of this
series.  I felt that was more than sufficient time, even with an
intervening weekend.  So if you don't like that I applied this without
your review, please be more punctual in the future.

Thank you.
My bad - reviewed when I was offline and forgot to send it out.

By luck this is not a big deal:

- Patches 1-4 are good.
- Patch 5 has some problems IMO, but all it does
is try to enable a previously non-working configuration, so
it seems ok to fix it up with follow-up patches as appropriate.

-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help