RE: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission
From: maowenan <hidden>
Date: 2017-07-31 03:30:00
From: maowenan <hidden>
Date: 2017-07-31 03:30:00
-----Original Message----- From: Neal Cardwell [mailto:ncardwell@google.com] Sent: Saturday, July 29, 2017 10:04 PM To: maowenan Cc: Netdev; David Miller; Yuchung Cheng; Nandita Dukkipati; weiyongjun (A); Chenweilong; Wangkefeng (Kevin) Subject: Re: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission On Fri, Jul 28, 2017 at 9:39 PM, maowenan [off-list ref] wrote:quoted
[Mao Wenan]ok, We have reproduced this issue with packetdrill yesterday, there is no the same issue when TLP send new data packet, RTO will be fired and retransmit packet.That's great to hear that you were able to reproduce this with packetdrill. Would you be able to share the packetdrill scripts that reproduce your issues? I would like to make sure our proposed patch addresses your scenarios as well.
[Mao Wenan]please refer to the attachment, test.pkt is packetdrill script. In test.pcap, packet number 17 is the TLP probe, packet number 218 is the retransmission packet because client don't send data packet to server. From the capture time, there are about 6 seconds the retransmission packet can be sent, and this time can be added more as long as client send data packet continually. I have reproduced this issue in Linux 4.13-rc3, 3.10, 4.1. Please check the timing When you use test.pkt to reproduce in your environment.
thanks, neal