Re: [Patch net] team: use a larger struct for mac address
From: kbuild test robot <hidden>
Date: 2017-07-21 13:08:41
Hi Cong, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Cong-Wang/team-use-a-larger-struct-for-mac-address/20170721-203849 config: i386-randconfig-x019-07211017 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/net/team/team.c: In function '__set_port_dev_addr':
quoted
drivers/net/team/team.c:67:39: error: passing argument 2 of 'dev_set_mac_address' from incompatible pointer type [-Werror=incompatible-pointer-types]
return dev_set_mac_address(port_dev, &addr);
^
In file included from drivers/net/team/team.c:20:0:
include/linux/netdevice.h:3290:5: note: expected 'struct sockaddr *' but argument is of type 'struct __kernel_sockaddr_storage *'
int dev_set_mac_address(struct net_device *, struct sockaddr *);
^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/dev_set_mac_address +67 drivers/net/team/team.c
3d249d4c Jiri Pirko 2011-11-11 55
3d249d4c Jiri Pirko 2011-11-11 56 /*
1d76efe1 Jiri Pirko 2012-08-17 57 * Since the ability to change device address for open port device is tested in
3d249d4c Jiri Pirko 2011-11-11 58 * team_port_add, this function can be called without control of return value
3d249d4c Jiri Pirko 2011-11-11 59 */
1d76efe1 Jiri Pirko 2012-08-17 60 static int __set_port_dev_addr(struct net_device *port_dev,
3d249d4c Jiri Pirko 2011-11-11 61 const unsigned char *dev_addr)
3d249d4c Jiri Pirko 2011-11-11 62 {
44118243 Cong Wang 2017-07-20 63 struct sockaddr_storage addr;
3d249d4c Jiri Pirko 2011-11-11 64
44118243 Cong Wang 2017-07-20 65 memcpy(addr.__data, dev_addr, port_dev->addr_len);
44118243 Cong Wang 2017-07-20 66 addr.ss_family = port_dev->type;
3d249d4c Jiri Pirko 2011-11-11 @67 return dev_set_mac_address(port_dev, &addr);
3d249d4c Jiri Pirko 2011-11-11 68 }
3d249d4c Jiri Pirko 2011-11-11 69
:::::: The code at line 67 was first introduced by commit
:::::: 3d249d4ca7d0ed6629a135ea1ea21c72286c0d80 net: introduce ethernet teaming device
:::::: TO: Jiri Pirko [off-list ref]
:::::: CC: David S. Miller [off-list ref]
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation Attachments
- .config.gz [application/gzip] 27281 bytes