Thread (9 messages) 9 messages, 2 authors, 2017-07-10

Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register()

From: Richard Cochran <richardcochran@gmail.com>
Date: 2017-07-10 09:48:06
Also in: kernel-janitors

On Mon, Jul 10, 2017 at 12:38:16PM +0300, Dan Carpenter wrote:
There were two buggy commits so I chose the ealier one.  The other buggy
No, you are mistaken.  In the original patch, NULL or PTR_ERR were
returned on error, and that was not a bug.

If you want to correct the present version of ptp_clock_register() to
always return a valid pointer or PTR_ERR (like the kerneldoc says), be
my guest, but please say that in the change log and reference the
correct commit (namely the one related to disabling POSIX clocks.)

Thanks,
Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help