Re: [PATCH] mwifiex: fix compile warning of unused variable
From: Kalle Valo <hidden>
Date: 2017-07-06 07:57:41
Also in:
linux-wireless
From: Kalle Valo <hidden>
Date: 2017-07-06 07:57:41
Also in:
linux-wireless
Shawn Lin [off-list ref] writes:
We got a compile warning shows below: drivers/net/wireless/marvell/mwifiex/sdio.c: In function 'mwifiex_sdio_remove': drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Per the code, it didn't check if mwifiex_sdio_read_fw_status finish successfully. We should at least check the return of mwifiex_sdio_read_fw_status, otherwise the following check of firmware_stat and adapter->mfg_mode is pointless as the device is probably dead.
I don't see that warning, any ideas why? My compiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 -- Kalle Valo