Thread (3 messages) 3 messages, 2 authors, 2017-07-04

Re: [PATCH net-next] bpf: fix return in load_bpf_file

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2017-07-04 22:14:48

On 07/04/2017 11:51 PM, Lawrence Brakmo wrote:
The function load_bpf_file ignores the return value of
load_and_attach(), so even if load_and_attach() returns an error,
load_bpf_file() will return 0.

Now, load_bpf_file() can call load_and_attach() multiple times and some
can succeed and some could fail. I think the correct behavor is to
return error on the first failed load_and_attach().
Your SOB is missing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help