Thread (25 messages) flat view 25 messages, 5 authors, 2017-06-09
STALE3391d

Revision v2 of 4 in this series.

Revisions (4)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v2 [diff vs current]
  4. v2 current

Re: [PATCH v2 3/8] net: mvmdio: use GENMASK for masks

From: Sergei Shtylyov <hidden>
Date: 2017-06-08 10:35:38
Also in: linux-arm-kernel

Hello!

On 6/8/2017 12:26 PM, Antoine Tenart wrote:
quoted hunk ↗ jump to hunk
Cosmetic patch to use the GENMASK helper for masks.

Signed-off-by: Antoine Tenart <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/marvell/mvmdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
index 17b518b13ae3..96af8d57d9e5 100644
--- a/drivers/net/ethernet/marvell/mvmdio.c
+++ b/drivers/net/ethernet/marvell/mvmdio.c
@@ -138,7 +138,7 @@ static int orion_mdio_read(struct mii_bus *bus, int mii_id,
 		goto out;
 	}

-	ret = val & 0xFFFF;
+	ret = val & GENMASK(15,0);
    Need a space after comma.

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help