Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
From: David Miller <hidden>
Date: 2017-06-29 20:05:18
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: David Miller <hidden>
Date: 2017-06-29 20:05:18
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Corentin Labbe <redacted> Date: Thu, 29 Jun 2017 19:02:38 +0200
On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote:quoted
From: Corentin Labbe <redacted> Date: Tue, 27 Jun 2017 11:28:01 +0200quoted
The current way to find if the phy is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the internal one. By using phy-mode = "internal" we permit to have an external PHY with the same mode than the internal one. Reported-by: André Przywara <redacted> Signed-off-by: Corentin Labbe <redacted>Series applied. Please provide a proper "[PATCH 0/n] " header posting next time.Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it. Regards Sorry again, I should have sent a comment for waiting.
Please send me a revert patch, when I say I've applied it I already pushed it out to my GIT tree.