Re: [PATCH] rsi: add in missing RSI_FSM_STATES into array fsm_state
From: Kalle Valo <hidden>
Date: 2017-06-28 16:22:17
Also in:
kernel-janitors, linux-wireless, lkml
From: Kalle Valo <hidden>
Date: 2017-06-28 16:22:17
Also in:
kernel-janitors, linux-wireless, lkml
Colin King [off-list ref] writes:
From: Colin Ian King <redacted>
Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED
and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state
was not updated to match. This can lead to an array overrun when
accessing the latter two states in fsm_state. Fix this by adding in
the missing states.
Detected by CoverityScan, CID#1398379 ("Illegal address computation")
Fixes: 9920322ccd8e04 ("rsi: add tx frame for common device configuration")
Fixes: 015e367494c1d5 ("rsi: Register interrupt handler before firmware load")
This is very much nitpicking, no need to resend because of this, but the
preferred format is to to use 12 chars for the commit id:
Fixes: 9920322ccd8e ("rsi: add tx frame for common device configuration")
Fixes: 015e367494c1 ("rsi: Register interrupt handler before firmware load")
Documentation/process/submitting-patches.rst contains a nice tip how you
can get that automatically with git:
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
--
Kalle Valo