Thread (6 messages) flat view 6 messages, 4 authors, 2017-06-28

Re: [PATCH][net-next] qtnfmac: fix uninitialized return code in ret

From: Sergey Matyukevich <hidden>
Date: 2017-06-22 08:25:31
Also in: kernel-janitors, linux-wireless, lkml

Not related to your patch but qtnf_map_bar() should be changed not to
return NULL.  When functions return both NULL and error pointers the
NULL is supposed to be a special type of success return.  Here it is
just a fail return where we forgot to set the error code to
ERR_PTR(-ENOMEM).
Thanks for reporting! FWIW it is not a bug, all the checks of pci maps
are in place. Though having both ERR_PTR and NULL in return indeed
looks confusing. We will add a fix in the upcoming cleanup series.

Regards,
Sergey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help