Thread (1 message) 1 message, 1 author, 2017-06-22

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

From: Bjørn Mork <bjorn@mork.no>
Date: 2017-06-22 08:14:57
Also in: lkml

Jay Vosburgh [off-list ref] writes:
Michael J Dilmore [off-list ref] wrote:
quoted
if (WARN_ON(!new_active_slave) {
   netdev_dbg("Can't add new active slave - pointer null");
   return ERROR_CODE
}
	In general, yes, but in this case, the condition should be
impossible to hit, so BUG_ON seems appropriate.
If it really is impossible then you should simply remove the test. No
need to test for the impossible, is there?


Bjørn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help